Improve capabilities reporting #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a list of attributes marked as "deprecated", but that are still necessary for 2.x applications; - also, set the size of written value, which is implicit for 3.x applications, but which is expected by (some) 2.x ones.
Some catalog functions are required in order for the minimum driver level to be achieved, so that apps can work with it. However, not all of them have a current backing in ES/SQL. For these, a fake local empty answer is provided. With this change, some 2.x apps can now inquiry the columns count and type (which 3.x apps would typically assume), which didn't work before. The rest remains unchanged: the app will fetch no row and the call succeeds.
- the function fakes an empty answer, no ES/SQL backing atp.
- updated README - removed stale code in build.bat
- the catalog function will now propagate to ES/SQL the SQL type the app is inquiring for (when not using the _ALL wildcard).
- add an early check for connection logging destination directory; - if a connection-level logger can't be initialized, the failure is now logged in the "general" logger, if available.
Closed
edsavage
approved these changes
Nov 21, 2018
driver/catalogue.c
Outdated
| STMT_FORCE_NODATA(STMH(hstmt)); | ||
| return SQL_SUCCESS; | ||
| /*INDENT-OFF*/ | ||
| # define SPECIAL_COLUMNS_EMPTY \ |
There was a problem hiding this comment.
nit: rename to FOREIGN_KEYS_EMPTY
There was a problem hiding this comment.
Oh, nice. Thanks for spotting it. Fixed now.
- fix copy&paste error.
bpintea
added a commit
that referenced
this pull request
Dec 13, 2018
* add "deprecated" SQLGetInfo attributes support - add a list of attributes marked as "deprecated", but that are still necessary for 2.x applications; - also, set the size of written value, which is implicit for 3.x applications, but which is expected by (some) 2.x ones. * fix: add "fake" answers to unsupported catalog fn Some catalog functions are required in order for the minimum driver level to be achieved, so that apps can work with it. However, not all of them have a current backing in ES/SQL. For these, a fake local empty answer is provided. With this change, some 2.x apps can now inquiry the columns count and type (which 3.x apps would typically assume), which didn't work before. The rest remains unchanged: the app will fetch no row and the call succeeds. * add SQLStatistics catalog function support - the function fakes an empty answer, no ES/SQL backing atp. * fix: update VS package reqs to cover DSN editor - updated README - removed stale code in build.bat * minor improvements in connection attributes handling * add support for filtering in SQLGetTypeInfo - the catalog function will now propagate to ES/SQL the SQL type the app is inquiring for (when not using the _ALL wildcard). * expose SQLStatistics to the API * minor connection logging setting validation - add an early check for connection logging destination directory; - if a connection-level logger can't be initialized, the failure is now logged in the "general" logger, if available. * fix: s/SPECIAL_COLUMNS_EMPTY/FOREIGN_KEYS_EMPTY - fix copy&paste error. (cherry picked from commit 8d10a5f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few improvements in driver's capabilities reporting to the client application:
SQLGetInfo()are now supported (mostly for the 2.x apps);SQLStatistics()is added to the list of facade catalog functions;SQLGetTypeInfo()will forward to ES/SQL the type the app wants to filter the result by.